Update uri_to_obj_class_map to support additional supported termination endpoints #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
requested changes
Apr 21, 2025
There was a problem hiding this comment.
@bcollet sorry for the late response on this, getting caught up after NetBox 4.3 work. This looks good and thank you for the work. I think it also needs PowerFeed (looking at https://github.com/netbox-community/netbox/blob/main/netbox/dcim/constants.py#L99) Can you please check and add that one is as well.
|
@arthanson no worries! I added support for |
arthanson
previously approved these changes
May 8, 2025
|
Fixed in #684 - had to create another branch to fix test run. closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #674
The PR proposes to add the following types to
uri_to_obj_class_mapto return the appropriate object type when tracing a path: